Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #32 #33

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Fix #32 #33

merged 3 commits into from
Dec 15, 2024

Conversation

jgraef
Copy link
Owner

@jgraef jgraef commented Dec 14, 2024

Fixes #32

  1. Added futures-03-sink to async-tungstenite's features.
  2. Fixed a bug in async-tungstenite (see PR) and changed the dependency to use that PR for now

I'll wait with merging this to see if we can get rid of the git dependency.

@jgraef
Copy link
Owner Author

jgraef commented Dec 15, 2024

async-tungstenite merged the patch and I bumped the dependency.

But when compiling the wasm example I get:

error[E0310]: the parameter type `Fut` may not live long enough
  --> /home/emma/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.30/src/stream/futures_unordered/task.rs:81:9
   |
81 |         waker_ref(this)
   |         ^^^^^^^^^^^^^^^
   |         |
   |         the parameter type `Fut` must be valid for the static lifetime...
   |         ...so that the type `Fut` will meet its required lifetime bounds
   |
help: consider adding an explicit lifetime bound
   |
78 | impl<Fut: 'static> Task<Fut> {
   |         +++++++++

I got this error before while investigating the async-tungstenite bug, but could not reproduce.

@jgraef
Copy link
Owner Author

jgraef commented Dec 15, 2024

This error is caused by some dependency pulling in futures-util 0.3.30, which has been yanked (might be related to this). Pinning futures-util to >=0.3.31 fixes this.

@jgraef jgraef merged commit bd20c37 into main Dec 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] async-tungstenite missing features
1 participant