Fixed bug in MicroMessageEncoder while encoding object with size bigg… · jgauffin/Griffin.Framework@904adbe

jgauffin · 2016-08-18T17:49:53Z

did you change the line endings? because the diff is wierd

gribunin · 2016-08-19T08:37:46Z

Yes, I noticed that too, actually not sure why that happened. I am editing files in Visual Studio 2015, didnt do any special settings. Could you advice what I need to do to bring it back to normal? BTW, I have found a couple of other bugs, one is severe (seems to be a copy-paste bug), -- in MicroMessageEncoder.cs, line 128 you have: _bodyStream.Write(.... instead of: _bodyStream.Read(.. so the objects with serialized size bigger than 65535 are not sent correctly. Sincerely yours, Kirill Gribunin 2016-08-18 20:49 GMT+03:00 Jonas Gauffin [email protected]:

…

did you change the line endings? because the diff is wierd — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub 904adbe#commitcomment-18693321, or mute the thread https://github.com/notifications/unsubscribe-auth/AJtnQ7V46kgN9FC3cj9KSw0GnJJLtoNiks5qhJtCgaJpZM4Jnvpo .

jgauffin · 2016-08-22T17:37:02Z

what kind of line endings do you have specified? I typically use "as-is"

jgauffin · 2016-08-22T17:56:50Z

the write thing has been corrected in the last commit. What more did you correct?

gribunin · 2016-09-09T08:27:36Z

Sorry for late reply. There was a small fix for typo in ReceiveAsync in ChannelTcpClient.cs, cancellation token was ignored:

…

---

--- C:/Users/kirill/AppData/Local/Temp/ChannelTcpClient.cs-rev194.svn000.tmp.cs Яђ рту 12 22:09:27 2016 +++ C:/Users/kirill/AppData/Local/Temp/ChannelTcpClient.cs-rev195.svn000.tmp.cs Тё рту 14 18:34:48 2016 @@ -229,7 +229,7 @@ namespace Griffin.Net /// </returns> public Task<object> ReceiveAsync(CancellationToken cancellation) { - return ReceiveAsync(TimeSpan.FromMilliseconds(-1), CancellationToken.None); - ``` return ReceiveAsync(TimeSpan.FromMilliseconds(-1), ``` cancellation); } ``` /// <summary> ``` --- Also, now once in a while I am facing the problem with infinite recursion in the server code which causes service to crash. The exact reason I haven't figured yet, seems that in HandleRemoteDisconnect some exception is raised always which leads to calling HandleRemoteDisconnect again: Yours sincerely, Kirill Gribunin 2016-08-22 20:56 GMT+03:00 Jonas Gauffin [email protected]:

the write thing has been corrected in the last commit. What more did you correct? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub 904adbe#commitcomment-18729682, or mute the thread https://github.com/notifications/unsubscribe-auth/AJtnQyNhxsl-7l9Pq2XIHyytpqYOe0yqks5qieLjgaJpZM4Jnvpo .

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Commit

There are no files selected for viewing

5 comments on commit `904adbe`

jgauffin commented on `904adbe` Aug 18, 2016

gribunin commented on `904adbe` Aug 19, 2016 via email

jgauffin commented on `904adbe` Aug 22, 2016

jgauffin commented on `904adbe` Aug 22, 2016

gribunin commented on `904adbe` Sep 9, 2016 via email

Commit

There are no files selected for viewing

5 comments on commit 904adbe

jgauffin commented on 904adbe Aug 18, 2016

Choose a reason for hiding this comment

gribunin commented on 904adbe Aug 19, 2016 via email

Choose a reason for hiding this comment

jgauffin commented on 904adbe Aug 22, 2016

Choose a reason for hiding this comment

jgauffin commented on 904adbe Aug 22, 2016

Choose a reason for hiding this comment

gribunin commented on 904adbe Sep 9, 2016 via email

Choose a reason for hiding this comment

5 comments on commit `904adbe`

jgauffin commented on `904adbe` Aug 18, 2016

gribunin commented on `904adbe` Aug 19, 2016 via email

jgauffin commented on `904adbe` Aug 22, 2016

jgauffin commented on `904adbe` Aug 22, 2016

gribunin commented on `904adbe` Sep 9, 2016 via email