This repository has been archived by the owner on Mar 20, 2019. It is now read-only.
fix location of <key> elements in graphml export #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to cancel this PR for now, I need to check through everything, including the tests to make sure it's fine. I'm not used to git, sorry about the messy history. I tried to figure out how to squash commits so your history is cleaner. I think I did it wrong. I'll be back soon with a proper PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #103
I think this might be the only change necessary to put the
<key>s in the correct location. It also looks like the Reader class should be able to read it back in just fine.I haven't built or tested this myself, yet, I'm not really set up for Java work.
Any input is appreciated. I'm using another library to consume this GraphML and this bug is actually breaking the other library.