Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing snapshot test #15497

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Conversation

phryneas
Copy link
Contributor

@phryneas phryneas commented Feb 9, 2025

Summary

This just fixes the test @SimenB noted to be failing here: #15480 (comment)

It seems that the error output slightly changed in node 23.7 and didn't match the .indexOf anymore.

Test plan

This PR quite literally updates a test ;)

Copy link

netlify bot commented Feb 9, 2025

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3d4a794
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/67a90a26816a3c000866a292
😎 Deploy Preview https://deploy-preview-15497--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@SimenB SimenB merged commit dc9f98c into jestjs:main Feb 9, 2025
85 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants