fix: remove optional param

jestjs · Feb 11, 2025 · 1accf78 · 1accf78
1 parent 43f6175
commit 1accf78
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/packages/jest-resolve/src/__tests__/resolve.test.ts b/packages/jest-resolve/src/__tests__/resolve.test.ts
@@ -742,7 +742,9 @@ describe('getMockModuleAsync', () => {
     } as ResolverConfig);
     const src = require.resolve('../');
 
-    await resolver.resolveModuleAsync(src, 'dependentModule');
+    await resolver.resolveModuleAsync(src, 'dependentModule', {
+      conditions: ['browser'],
+    });
 
     expect(mockUserResolverAsync.async).toHaveBeenCalled();
     expect(mockUserResolverAsync.async.mock.calls[0][0]).toBe(
@@ -752,6 +754,10 @@ describe('getMockModuleAsync', () => {
       'basedir',
       path.dirname(src),
     );
+    expect(mockUserResolverAsync.async.mock.calls[0][1]).toHaveProperty(
+      'conditions',
+      ['browser'],
+    );
   });
 });
 

diff --git a/packages/jest-resolve/src/resolver.ts b/packages/jest-resolve/src/resolver.ts
@@ -502,7 +502,7 @@ export default class Resolver {
   async getMockModuleAsync(
     from: string,
     name: string,
-    options?: Pick<ResolveModuleConfig, 'conditions'>,
+    options: Pick<ResolveModuleConfig, 'conditions'>,
   ): Promise<string | null> {
     const mock = this._moduleMap.getMockModule(name);
     if (mock) {
@@ -601,7 +601,7 @@ export default class Resolver {
       moduleName,
       options,
     );
-    const mockPath = await this._getMockPathAsync(from, moduleName);
+    const mockPath = await this._getMockPathAsync(from, moduleName, options);
 
     const sep = path.delimiter;
     const id =
@@ -671,7 +671,7 @@ export default class Resolver {
   private async _getMockPathAsync(
     from: string,
     moduleName: string,
-    options?: Pick<ResolveModuleConfig, 'conditions'>,
+    options: Pick<ResolveModuleConfig, 'conditions'>,
   ): Promise<string | null> {
     return this.isCoreModule(moduleName)
       ? null