WIP: collapse/uncollapse all files in tree

[mtrajano]

Seems like this feature is highly requested #4095 #3554

Did a quick wip pr. I got the core functionality working with files and had some questions on what can be improved in order to polish it more. I.e. What keymaps if any to add to these, should the functionality be to toggle vs collapse and uncollapse separately, and if this should be added anywhere else (right now it's just for the file tree)

Once I figure this out I can add the tests, documentations and anything else that's missing. I'm also pretty new to the language so if there's a way I can structure this better please let me know

Example of functionality working:

[stefanhaller]

What keymaps if any to add to these

I could imagine - for collapsing, and = for expanding. At least they are easy to reach on a US keyboard layout. Anybody got any better ideas?

should the functionality be to toggle vs collapse and uncollapse separately

I would probably do separate ones. For toggling it wouldn't be quite clear what the exact logic would be.

and if this should be added anywhere else (right now it's just for the file tree)

Yes, in commits_files_controller.go; this handles the list of files that you see when pressing enter on a commit. I'm not aware of any other places besides these two.

[jesseduffield]

I could imagine - for collapsing, and = for expanding.

That sounds good to me