New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing dependency to installation instructions #3775

Open

moritztim wants to merge 2 commits into jesseduffield:master from moritztim:patch-1

moritztim commented Jul 25, 2024 •

edited

Loading

PR Description
The installation instructions did not check if curl is installed, which is not the case out of the box.
Please check if the PR fulfills these requirements

Cheatsheets are up-to-date (run go generate ./...)
Code has been formatted (see here)
Tests have been added/updated (see here for the integration test guide)
Text is internationalised (see here)
Docs have been updated if necessary
You've read through your own file changes for silly mistakes etc

moritztim marked this pull request as draft

July 25, 2024 09:10

moritztim marked this pull request as ready for review

July 25, 2024 09:13

jesseduffield approved these changes

View reviewed changes

moritztim added 2 commits

August 17, 2024 15:22


          Add missing dependency to installation instructions

4d36001

curl does not come preinstalled with ubuntu.


          remove accidentally pasted text

e6de4a9

jesseduffield force-pushed the patch-1 branch from 3cb28e8 to e6de4a9 Compare

August 17, 2024 05:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet