Bags Kata

Introduction

Hi! This is my solution. It is written in PHP because I'm more comfortable to configure this language.

Choice

• Use Hexagonal architecture: for this challenge I choose a clean architecture. I create 3 separate layers: application: point of entry, Domain: all logic, and repository: access to data. Maybe I could use DDD, using Value Object,... but It a sunny Saturday ;)
• Use TDD: As you can see in my git history, I created a test and then command/commandHandler. Maybe I could improve tests by creating tests for domain and maybe acceptance tests.
• Simple design: I created the minimum test and minimum documentation, if you need more information, please tell me.
• Check code: PHP is a dynamic language, I added some tools like PHPStan to analyze the code. Furthermore, I use PHP-CS-Fixer to reformate code according to PHP guidelines. I use mutant testing to improve my tests
• Docker: I create a Makefile (I usually forget Docker commands) and add a simple PHP image for development

Improvement

• Create Value Objects for more semantic and validation
• Add more test: as I said before, this project needs more
• Kill all mutangs

How to run

You can use Docker, and the Makefile to run.

$ make
all                  run all check before commit
build                Build the container
deps                 install dependencies
help                 Prints this help.
fixer                run php-cs-fixer
phpstan              run phpstan
sh                   open sh inside container
test                 run all tests
test-mutation        run tests with mutation