Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save posted reports to database. #27

Merged
merged 11 commits into from
Dec 28, 2018
Merged

Save posted reports to database. #27

merged 11 commits into from
Dec 28, 2018
+246 −80

Conversation

jeschkies
Copy link
Owner

@jeschkies jeschkies commented Dec 27, 2018 •
edited
Loading

Summary:

Test with

sudo docker run \
  -e POSTGRES_USER=kjeschkies \
  -e POSTGRES_PASSWORD=1234 \
  -p 5432:5432 \
  postgres:10.5-alpine

./gradlew populateDatabase

curl \
  -F commit=deafbeef \
  -F report="@fixtures/deadbeef.xml" \
  -F report="@fixtures/exception.xml" \
  "localhost:8080/reports/jeschkies/unit/system-test"

@jeschkies jeschkies requested a review from zen-dog December 27, 2018 15:44
jeschkies
jeschkies commented Dec 27, 2018
View reviewed changes
zen-dog
zen-dog approved these changes Dec 28, 2018
View reviewed changes
Copy link
Collaborator

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bunch of nits and naming convention suggestions. Otherwise lgtm.

P.S. Validation nits will be a bigger story so you could just leave TODOs there (so I don't forget them later)

@jeschkies
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request Dec 28, 2018
@bors @jeschkies
Merge #27
74269c1 
27: Save posted reports to database. r=jeschkies a=jeschkies

Summary:

Test with
```
sudo docker run \
  -e POSTGRES_USER=kjeschkies \
  -e POSTGRES_PASSWORD=1234 \
  -p 5432:5432 \
  postgres:10.5-alpine

./gradlew populateDatabase

curl \
  -F commit=deafbeef \
  -F report="@fixtures/deadbeef.xml" \
  -F report="@fixtures/exception.xml" \
  "localhost:8080/reports/jeschkies/unit/system-test"
```

Co-authored-by: Karsten Jeschkies <jeskar@web.de>
@bors
Copy link
Contributor

bors bot commented Dec 28, 2018

Build succeeded

@bors bors bot merged commit c982569 into master Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zen-dog zen-dog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeschkies @zen-dog