Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate targets into os and baremetal-sdk parts #4842

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Separate targets into os and baremetal-sdk parts #4842

merged 1 commit into from
Dec 6, 2021

Conversation

rtakacs
Copy link
Contributor

@rtakacs rtakacs commented Dec 1, 2021 •
edited
Loading

Currently, all the targets are added to targets folder. Their names are logically different, based on the appropriate OS, OS - board, SDK, or board:

- targets
  - curie_bsp
  - esp8266
  - esp-idf
  - mbedos5
  - nuttx-stm32f4
  - openwrt
  - particle
  - riot-stm32f4
  - zephyr

This patch allows targets to be a bit more uniform:

  • separate targets into os and baremetal-sdk parts
  • remove board names from target names since targets are rather for OSs and SDKs
    • the concrete boards are mentioned in README.md files
- targets
  + os
  |  - mbedos5
  |  - nuttx
  |  - openwrt
  |  - riot
  |  - zephyr
  |
  + baremetal-sdk
     - curie-bsp
     - esp8266-rtos-sdk
     - esp-idf
     - particle

@ossy-szeged ossy-szeged added the targets Related to embedding target devices label Dec 2, 2021
@rtakacs rtakacs force-pushed the separate-targets branch 2 times, most recently from 59faaa3 to f7afb8d Compare December 3, 2021 09:15
rerobika
rerobika approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtakacs
Copy link
Contributor Author

rtakacs commented Dec 3, 2021

Let's wait for #4829 to be merged before this change.

robertsipka
robertsipka approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtakacs
Separate targets into os and baremetal-sdk parts
3798846 
JerryScript-DCO-1.0-Signed-off-by: Roland Takacs [email protected]
@robertsipka robertsipka merged commit af297bc into jerryscript-project:master Dec 6, 2021
@rtakacs rtakacs deleted the separate-targets branch December 6, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rerobika rerobika rerobika approved these changes

@robertsipka robertsipka robertsipka approved these changes

Assignees
No one assigned
Labels
targets Related to embedding target devices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rtakacs @robertsipka @rerobika @ossy-szeged