Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial methods comparison table #324

Merged

Conversation

szhan
Copy link
Collaborator

@szhan szhan commented Feb 13, 2025

Partially address #322

@szhan
Copy link
Collaborator Author

szhan commented Feb 13, 2025

@jeromekelleher Any suggestions for the formatting? How should we encode N/A or recombinants with more than one breakpoint?

@jeromekelleher
Copy link
Owner

How many > 2 parent recombinants are there in Pango? It it's only a handful I would suggest we deal with them separately and focus for now on the two parent case. We can add in the extra columns or make a new table for the complex ones later if we like.

Copy link
Owner

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you group by pango, please, to make it easy to compare these directly in the table?

@szhan
Copy link
Collaborator Author

szhan commented Feb 13, 2025

How many > 2 parent recombinants are there in Pango? It it's only a handful I would suggest we deal with them separately and focus for now on the two parent case. We can add in the extra columns or make a new table for the complex ones later if we like.

In the current alias key, there are:
Total Pango X: 144
One breakpoint: 123
More breakpoints: 21

@szhan
Copy link
Collaborator Author

szhan commented Feb 13, 2025

Okay, I'll separate the one-breakpoint and more complex cases.

@jeromekelleher
Copy link
Owner

I think that's worthwhile, it'll help to analyse this relatively simple subset separately.

@jeromekelleher
Copy link
Owner

Shall we merge?

@szhan
Copy link
Collaborator Author

szhan commented Feb 13, 2025

Wait, I'm adding some more results.

@szhan szhan force-pushed the initial_methods_comparison_table branch from 1c318c2 to 6e040e4 Compare February 13, 2025 15:07
@szhan
Copy link
Collaborator Author

szhan commented Feb 13, 2025

Yep ready for merging.

@szhan
Copy link
Collaborator Author

szhan commented Feb 13, 2025

Note that in the RecombinHunt results, when the left Pango parent is "na", it means that the sequences for that Pango X was not in the dataset. Also, when the left Pango parent is indicated but the right Pango parent is "na", it means that RecombinHunt identified the Pango as a non-recombinant.

@szhan
Copy link
Collaborator Author

szhan commented Feb 13, 2025

Ah!!! I forgot to sort by Pango X label.

@szhan szhan changed the title Initial methods comparison table, ground truth and Recombinant-GISAID Initial methods comparison table: ground truth, Recombinant-GISAID, Recombinant-Nextstrain Feb 13, 2025
@szhan
Copy link
Collaborator Author

szhan commented Feb 13, 2025

Actually, hold on. I might as well add the CovRecomb results too.

@szhan szhan force-pushed the initial_methods_comparison_table branch from 03ff2be to 6e31b02 Compare February 13, 2025 17:13
@szhan
Copy link
Collaborator Author

szhan commented Feb 13, 2025

Okay, not including the CovRecomb results for now, because it seems like a pain. There should be enough to do a first-pass analysis. Ready for merging @jeromekelleher.

@szhan szhan changed the title Initial methods comparison table: ground truth, Recombinant-GISAID, Recombinant-Nextstrain Initial methods comparison table Feb 13, 2025
@jeromekelleher jeromekelleher merged commit 6c311b2 into jeromekelleher:main Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants