Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring private methods to be protected #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sawtell
Copy link

@sawtell sawtell commented Jan 21, 2022

Motivation

Not all imports are simple CSV column to table column mappings. When there are complex relationships as part of the import data the ability to alter the process is required to avoid errors or missing related content.

Changes

Empower users to alter parts of the import process they deem fit by making private methods protected

@tristan-thar
Copy link

This is much needed. I tried to run an import of products that have an auto generated UUID. However the package is using the DB facade to insert the rows instead of Eloquent, so no model events are fired, thus the uuid is never generated.
I had to write my own implementation because there was no way to override the private insertRows() function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants