-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode fixes #69
Dark mode fixes #69
Conversation
I also don't have any Vive base stations, their support is completely theoretical. You can enable getting fake devices in the list for testing by going to But I'll have a look at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good. Could you also change the selected background for the main devices page, the nicknames page and the Vive Base station ids page. (For the Nickname page and the Vive Base station ids page you can tap the 🚫 10 times to generate fake data (debug only)).
I'm not sure what to change the background color to because Theme.of(context).selectedRowColor
doesn't look good in dark mode.
I have Vive Base Stations so maybe I can help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks for the help.
closes #65
i do not have any vive basestations to test those features. can you check, @jeroen1602 ?