fix(regression): Make the Downloader honour the proxy.nonproxyhosts ODC Setting #7077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…legacy configuration for non-proxy hosts when configuring the proxy from the legacy ODC Settings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #7202
Description of Change
As an extension to the fix for the Maven case covered by #7074 ensure that when the Downloader configures the proxy from the "legacy" ODC Settings properties the
proxy.nonproxyhostsis still honoured.Have test cases been added to cover the new functionality?
no, used manual testing with the CLI, a custom properties file and a local dockerized squid proxy to verify that the proxy-route was only taken for Downloader actions targeting hosts that don't match the proxy.nonproxyhosts settings