Login Form Target URL defined with Environment Variable #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thc202
reviewed
Oct 24, 2017
| @@ -557,6 +557,10 @@ private void checkParams(AbstractBuild<?, ?> build, BuildListener listener) thro | |||
| if (this.evaluatedTargetURL == null || this.evaluatedTargetURL.isEmpty()) throw new IllegalArgumentException("STARTING POINT (URL) IS MISSING, PROVIDED [ " + this.evaluatedTargetURL + " ]"); | |||
| else Utils.loggerMessage(listener, 1, "(EXP) STARTING POINT (URL) = [ {0} ]", this.evaluatedTargetURL); | |||
|
|
|||
| this.evaluatedLoginURL = envVars.expand(this.evaluatedLoginURL); | |||
| if (this.evaluatedLoginURL == null || this.evaluatedLoginURL.isEmpty()) throw new IllegalArgumentException("LOGIN FORM TARGET (URL) IS MISSING, PROVIDED [ " + this.evaluatedLoginURL + " ]"); | |||
There was a problem hiding this comment.
This validation should be performed only if authMode is true, otherwise it requires a login URL even if no authentication is enabled.
|
Looking over this pull request during the week. There was definitely a reason this was not a feature during initial development, will update once i go over my notes. Please squash the commits into one. |
|
Any update on this PR? We're currently blocked on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring Form-based Authentication, a user is unable to specify an environment variable in the Login Form Target URL field. This pull request allows an environment variable to be specified and expanded in that field.
This is a fix for JENKINS-47038.