New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hardcoded value with StandardCharset #217

Open

Pushkar-Mahajan4 wants to merge 2 commits into jenkinsci:master from Pushkar-Mahajan4:p4HookRefactor

Pushkar-Mahajan4 commented Nov 15, 2024 •

edited

Loading

Replaced hardcoded values like "UTF-8" with StandardCharsets.UTF_8 to follow best practices. This ensures better readability, avoids potential typos, and uses predefined constants for standard character sets.
Use lambda function for better readability
Log error msg in catch block

Let me know if this needs more work or any changes 😁

Pushkar-Mahajan4 added 2 commits

November 15, 2024 08:43


          Replace hardcoded value with StandatdCharset

257431c


          Use lambda function, log error msg

1c50fe1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet