Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize to latest versions supported by Java 8 #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sghill-rewrite
Copy link

@sghill-rewrite sghill-rewrite commented Jul 15, 2023

Hi!

This PR aims to modernize tooling and move this plugin closer to the recommended Jenkins baseline version without making the change too big. If this goes well, I can follow up with a subsequent PR to modernize further.

This PR was generated with an OpenRewrite recipe on Moderne.io.

index.jelly is a required file with the newer tooling.

I decided to remove the properties for jenkins.bom.artifactId and jenkins.bom.version because I thought it would simplify maintenance. SourceGraph showed this as the only repository that defines these properties.

Testing done

Ran mvn clean verify.

Submitter checklist

Preview Give feedback

@sghill
Copy link

sghill commented Jul 25, 2023

@orrc would you be able to look at this modernization PR or recommend someone who could?

@sghill
Copy link

sghill commented Aug 21, 2023

@jenkinsci/golang-plugin-developers are you able to take a look at this modernization PR? There are some other nice things we could do as well to reduce the burden for maintainers - like CD releases that happen entirely from GitHub Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants