This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
Major Bug fixes #162
Open
Major Bug fixes #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 29, 2020 11:17
martinda
suggested changes
Aug 30, 2020
kwhetstone
suggested changes
Sep 1, 2020
| @@ -70,7 +70,7 @@ private static JSONObject generateBuildSettings(final JSONObject buildSettings) | |||
| dockerInfo.put("base", buildSettings.getString("base")); | |||
| if (buildSettings.has("tag")) { | |||
| dockerInfo.put("tag", buildSettings.getString("tag")); | |||
| dockerInfo.put("build", "true"); | |||
| dockerInfo.put("build", "false"); | |||
There was a problem hiding this comment.
Dang, this sees like a pretty big change.... There should be a test that accompanies this to show that the problem existed and that the problem was solved by this particular change.
There was a problem hiding this comment.
This actually fails the testing at this time because the test expects "true". Setting docker to true actually fails, see #155 and this comment in #141.
Co-authored-by: Kristin Whetstone <[email protected]>
|
The test is still expecting false? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a) Changes the docker build to false: Prevents the docker in docker condition.
b) Changes the empty editor to now set the code.
c) Change title in
index.html