[JENKINS-74014] Extract inline JavaScript from `BuildTimestampWrapper…

…/global.jelly` (#76)
jenkinsci · Nov 6, 2024 · bcdf74e · bcdf74e
1 parent 135b826
commit bcdf74e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/src/main/java/com/orctom/jenkins/plugin/buildtimestamp/BuildTimestampWrapper.java b/src/main/java/com/orctom/jenkins/plugin/buildtimestamp/BuildTimestampWrapper.java
@@ -148,22 +148,22 @@ public FormValidation doCheckPattern(@QueryParameter("pattern") String patternPa
 			}
 		}
 
-		public FormValidation doCheckKey(@QueryParameter("key") String key) {
-			if (isVariableNameValid(key)) {
+		public FormValidation doCheckKey(@QueryParameter String value) {
+			if (isVariableNameValid(value)) {
 				return FormValidation.ok();
 			}
 			return FormValidation.error("Invalid variable name");
 		}
 
-		public FormValidation doCheckValue(@QueryParameter("value") String value) {
+		public FormValidation doCheckValue(@QueryParameter String value) {
 			if (isPatternValid(value)) {
 				return FormValidation.ok();
 			}
 			return FormValidation.error("Invalid pattern");
 		}
 
-		public FormValidation doCheckShiftExpression(@QueryParameter("shiftExpression") String shiftExpression) {
-			if (ShiftExpressionHelper.isShiftExpressionValid(shiftExpression)) {
+		public FormValidation doCheckShiftExpression(@QueryParameter String value) {
+			if (ShiftExpressionHelper.isShiftExpressionValid(value)) {
 				return FormValidation.ok();
 			}
 			return FormValidation.error("Invalid time shift expression");

diff --git a/...ain/resources/com/orctom/jenkins/plugin/buildtimestamp/BuildTimestampWrapper/global.jelly b/...ain/resources/com/orctom/jenkins/plugin/buildtimestamp/BuildTimestampWrapper/global.jelly
@@ -13,16 +13,16 @@
                 <f:repeatable field="extraProperties" items="${extraProperties}">
                     <table width="100%">
                         <f:entry title="Name:" field="key" help="/plugin/build-timestamp/help-name.html">
-                            <f:textbox field="key" value="${instance.key}"
-                                       checkUrl="'${rootURL}/descriptorByName/com.orctom.jenkins.plugin.buildtimestamp.BuildTimestampWrapper/checkKey?key='+escape(this.value)" />
+                            <f:textbox checkDependsOn=""
+                                       checkUrl="${rootURL}/descriptorByName/com.orctom.jenkins.plugin.buildtimestamp.BuildTimestampWrapper/checkKey" />
                         </f:entry>
                         <f:entry title="Pattern:" field="value" help="/plugin/build-timestamp/help-pattern.html">
-                            <f:textbox field="value" value="${instance.value}"
-                                       checkUrl="'${rootURL}/descriptorByName/com.orctom.jenkins.plugin.buildtimestamp.BuildTimestampWrapper/checkValue?value='+escape(this.value)" />
+                            <f:textbox checkDependsOn=""
+                                       checkUrl="${rootURL}/descriptorByName/com.orctom.jenkins.plugin.buildtimestamp.BuildTimestampWrapper/checkValue" />
                         </f:entry>
                         <f:entry title="Shift timestamp:" field="shiftExpression" help="/plugin/build-timestamp/help-shiftExpression.html">
-                            <f:textbox field="shiftExpression" value="${instance.shiftExpression}"
-                                       checkUrl="'${rootURL}/descriptorByName/com.orctom.jenkins.plugin.buildtimestamp.BuildTimestampWrapper/checkShiftExpression?shiftExpression='+escape(this.value)" />
+                            <f:textbox checkDependsOn=""
+                                       checkUrl="${rootURL}/descriptorByName/com.orctom.jenkins.plugin.buildtimestamp.BuildTimestampWrapper/checkShiftExpression" />
                         </f:entry>
                         <f:entry title="">
                             <div align="right">