-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canary with Flagger #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktor Farcic <[email protected]>
Signed-off-by: Viktor Farcic <[email protected]>
Signed-off-by: Viktor Farcic <[email protected]>
Signed-off-by: Viktor Farcic <[email protected]>
Signed-off-by: Viktor Farcic <[email protected]>
Signed-off-by: Viktor Farcic <[email protected]>
Signed-off-by: Viktor Farcic <[email protected]>
Signed-off-by: Viktor Farcic <[email protected]>
Signed-off-by: Viktor Farcic <[email protected]>
Signed-off-by: Viktor Farcic <[email protected]>
Signed-off-by: Viktor Farcic <[email protected]>
Signed-off-by: Viktor Farcic <[email protected]>
for 6. we could use something like this idea jenkins-x/jx#5471 |
@vfarcic this is awesome - well played! Minor knit - we maybe want to make the canary provider |
we can look at supporting gloo/linkerd too later on though; lets not slow down this change happening |
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for canary deployments with Flagger and Istio to the Go build pack. If accepted, I can make a separate PR with the same set of additions to other build packs. All the changes are inside
if
statements so merging this PR will not affect users unless they change thecanary.enabled
value totrue
. I also used this opportunity to add the support for HPA (also not used without changing.This PR is useful by itself. Nevertheless, there are some pending tasks that could be done in separate PRs.
If this PR is merged, I can come back with PRs for 1) and 2) fairly quickly.