Confusion between contentEditable (the attribute) and `isContentEdi…

…table` (the interpretation)
jelmervdl · Nov 8, 2022 · c8a4aa2 · c8a4aa2
1 parent 5ef9ac9
commit c8a4aa2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/content/InPageTranslation.js b/src/content/InPageTranslation.js
@@ -664,7 +664,7 @@ export default class InPageTranslation {
 
         // Exclude editable elements for the same reason we don't translate the
         // contents of form input fields.
-        if (node.contentEditable === "true")
+        if (node.isContentEditable)
             return true;
 
         return false;

diff --git a/src/content/OutboundTranslation.js b/src/content/OutboundTranslation.js
@@ -460,7 +460,7 @@ export default class OutboundTranslation {
 	}
 
 	#usePreviewField() {
-		return this.#target?.isContentEditable === 'true';
+		return this.#target?.isContentEditable;
 	}
 
 	#renderPreviewField() {
@@ -541,7 +541,7 @@ export default class OutboundTranslation {
 	#setTargetValue(value) {
 		if ('value' in this.#target) {
 			setValueInput(this.#target, value);
-	  } else if (this.#target.isContentEditable === 'true') {
+	  } else if (this.#target.isContentEditable) {
 	  	setValueContentEditable(this.#target, value);
 		}
 		else