Update CI for 5.x branch #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadowghost
approved these changes
Mar 9, 2024
nyanmisaka
approved these changes
Mar 9, 2024
1. Ensure the upload happens to the /srv/incoming directory where the REPO_USER has permission to write. 2. Use "sudo" to move things into place as everything in the repo is root-owned.
The burnett01/rsync-deployments action doesn't create parent directories, which adds the requirement for an additional step to create the target directory, which I find messy. Switch to using appleboy/scp-action instead, which does create the parent directories as expected.
I don't know if this really affects anything, but ensures consistency with jellyfin-packaging actions
joshuaboniface
force-pushed
the
ci-update-5
branch
from
c0f21ed to
047ea43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Implements the same changes as #353 but for the 5.x branch/version.
Issues
N/A