[TheOneric] Speedup license extraction #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an intermediate measure improving build times with multiple jobs until the toplevel Makefile can properly handle parallelism. Cherry-picked from: libass@e3e0003
It exists in the toplevel Makefile.
Cherry-picked from: libass@0d8d68b
Apparently licensecheck has a high startup cost, so merging invocations
promises a neat speedup. However, currently some "\x{....} cannot be
represented as ascii" error messages appear in our logs. If that happens
licensecheck exits with 255, which omits all following files of the
same invocation and also prompts `find -exec .. {} +` or `xargs` to not
spawn any more invocations. If we were to simply merge invocations by
one of those means it would result in an incomplete COPYRIGHT file.
Those encoding errors appear to be due to an ASCII locale being set in
the container, so override LC_ALL to an UTF-8 one. To further make this
bit more resilient ensure licensecheck errors are no longer ignored by
capturing and processing its exit code.
Cherry-picked from: libass@cf04e03
The portable mkfifo approach works fine locally and worked fine in initial GHA testing, but now it started to run into various stalling issues on GHA. Presumably depending on whether the pipe is first written to or read from and attempts to find a simple workaround for it failed. Sometimes (but not always!) this is accompanied by an error like this: cannot open ./__LICENSE_EXTRACT_QUEUE.tmp: Interrupted system call So convert the script to bash and just use set -o pipefail. Cherry-picked from: libass@94cfe11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling from the upstream.
Original author: TheOneric
Part of libass#139 + non-PRed commits