improve gaps() time complexity for inclusive range map #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't initially realize that the inclusive range map is a completely different implementation. Implement an O(log n) initial seek for the inclusive range map, similar to abf6bec.
|
Hi Jeff, I was unable to run fuzz tests so far for this change and the previous change. I'm developing on an aarch64 Windows machine and rustc doesn't yet support fuzzing for my target. I'm currently installing WSL and giving fuzzing on Linux a try. I'll drop another note here after I run the fuzz tests. Thanks again for the very helpful library!. |
|
I tried out the two gaps fuzz targets for ~10 minutes each. Looks like no issues found! |
|
This change is part of addressing issue #103 |
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't initially realize that the inclusive range map is a completely different implementation. Implement an O(log n) initial seek for the inclusive range map, similar to abf6bec.