Improve time complexity of gaps() function #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RangeMap.gaps() function previously iterated over all ranges prior to the query range before returning the first overlapping gap. This results in a worst-case O(n) time complexity per query. Now the gaps() function reuses the overlaps() code to get an iterator to the first overlapping range in O(log(n)) time.
|
Thanks for this, Neeraj! Any chance you'd be interested in applying the same treatment to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RangeMap.gaps() function previously iterated
over all ranges prior to the query range before
returning the first overlapping gap. This results
in a worst-case O(n) time complexity per query.
Now the gaps() function reuses the overlaps() code to
get an iterator to the first overlapping range in O(log(n)) time.
Fixes issue #103.