Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: #180 Additional serializer infinityLoop when using FieldBitLength [3 Unit tests broken] #236

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mathiash98
Copy link

@mathiash98 mathiash98 commented Dec 17, 2024

Ref to #180

Infinity loop occurs when trying to parse a binary message that does not fit into the provided type.

This commit adds an additional check when parsing to throw exception if stream.AvailableForReading < 0 (I have used < -1 in order to Allow IOExceptionTest to pass).

This commit breaks following unit tests:

…tLength

Infinity loop occurs when trying to parse a binary message that does not fit into the provided type.

This commit adds an additional check when parsing to throw exception if stream.AvailableForReading < 0.

This commit breaks following unit tests:
- Issue55Tests
- ImmutableTest2
- IOExceptionTest - ShouldThrowIOExceptionNotInvalidOperationExceptionTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant