[media] Fix download of filenames with commas (aces#9510)

In the Media module, allows files with names containing commas to be downloaded (would previously result in an error).
jeffersoncasimir · Jan 17, 2025 · 78e430f · 78e430f
1 parent 9d94422
commit 78e430f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/modules/media/jsx/mediaIndex.js b/modules/media/jsx/mediaIndex.js
@@ -113,7 +113,11 @@ class MediaIndex extends Component {
                             + encodeURIComponent(row['File Name']);
         result = (
           <td className={style}>
-            <a href={downloadURL} target="_blank" download={row['File Name']}>
+            <a
+              href={downloadURL}
+              target="_blank"
+              download={encodeURIComponent(row['File Name'])}
+            >
               {cell}
             </a>
           </td>

diff --git a/php/libraries/FilesDownloadHandler.php b/php/libraries/FilesDownloadHandler.php
@@ -68,14 +68,15 @@ public function handle(ServerRequestInterface $request) : ResponseInterface
         }
         //Use basename to remove path traversal characters.
         $filename = $request->getAttribute('filename');
+
         if (empty($filename)) {
             return new \LORIS\Http\Response\JSON\BadRequest(
                 self::ERROR_EMPTY_FILENAME
             );
         }
 
         assert(is_string($filename) || $filename instanceof \Stringable);
-        $filename = \Utility::resolvePath(strval($filename));
+        $filename = urldecode(\Utility::resolvePath(strval($filename)));
 
         $targetPath = \Utility::appendForwardSlash(
             $this->downloadDirectory->getPathname()