Fix expression value infix generation

jeansossmeier · Apr 4, 2024 · d97b9ca · d97b9ca
1 parent 1eba776
commit d97b9ca
Showing 1 changed file with 12 additions and 13 deletions.
diff --git a/src/main/java/com/intuit/graphql/filter/ast/ExpressionValue.java b/src/main/java/com/intuit/graphql/filter/ast/ExpressionValue.java
@@ -37,21 +37,20 @@ public ExpressionValue(V value) {
      */
     @Override
     public String infix() {
-        StringBuilder infix = new StringBuilder("");
-        String result = null;
-        if (value != null) {
-            if (value instanceof Iterable) {
-                Iterable<V> vals = (Iterable<V>) value;
-                for (V val : vals) {
-                    infix.append(value.toString()).append(",");
-                }
-                result = infix.toString() == "" ? "" : infix.substring(0, infix.length()-1);
-            } else {
-                infix.append(value);
-                result = infix.toString();
+        final StringBuilder infix = new StringBuilder();
+        if (value == null) {
+            return null;
+        }
+
+        if (value instanceof Iterable) {
+            for (V val : (Iterable<V>) value) {
+                infix.append(val.toString()).append(",");
             }
+            return infix.toString() == "" ? "" : infix.substring(0, infix.length()-1);
+        } else {
+            infix.append(value);
+            return infix.toString();
         }
-        return result;
     }
 
     /**