-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add http cache #4160
feat: add http cache #4160
Conversation
I think we should probably make the cache optional doing something like the cache option for |
Nice idea, i will implement it By default the I will add a |
Hello @jdx I think it's done if you want to check 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is close, my main thing is that I think we should rename this since FileProvider sounds a bit generic and doesn't describe what these do very well. I suggested "RemoteTask" but I'm open to other ideas too.
@jdx ,from your point of view where is the best place to store the cache ? I use the
MISE_CACHE_DIR
but according to the documentation here i'm not really sure.