Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add http cache #4160

Merged
merged 12 commits into from
Jan 25, 2025
Merged

feat: add http cache #4160

merged 12 commits into from
Jan 25, 2025

Conversation

acesyde
Copy link
Contributor

@acesyde acesyde commented Jan 19, 2025

@jdx ,from your point of view where is the best place to store the cache ? I use the MISE_CACHE_DIR but according to the documentation here i'm not really sure.

@jdx
Copy link
Owner

jdx commented Jan 19, 2025

I think we should probably make the cache optional doing something like the cache option for exec() in templates where they enable it by offering a cache expiration duration. I think in general people won't want caching because if they wanted a static task they would just use a file and wouldn't need remote support.

@acesyde
Copy link
Contributor Author

acesyde commented Jan 20, 2025

Nice idea, i will implement it

By default the cache is by provider and enabled, for the local provider we don't use the cache

I will add a --no-cache to skip the cache

@acesyde
Copy link
Contributor Author

acesyde commented Jan 25, 2025

Hello @jdx

I think it's done if you want to check 👍

src/cli/run.rs Show resolved Hide resolved
src/task/file_providers/mod.rs Outdated Show resolved Hide resolved
Copy link
Owner

@jdx jdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is close, my main thing is that I think we should rename this since FileProvider sounds a bit generic and doesn't describe what these do very well. I suggested "RemoteTask" but I'm open to other ideas too.

src/cli/run.rs Outdated Show resolved Hide resolved
@acesyde acesyde requested a review from jdx January 25, 2025 15:51
@jdx jdx merged commit afa89de into jdx:main Jan 25, 2025
19 checks passed
@acesyde acesyde deleted the feture/cache branch January 25, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants