-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add PowerShell example #3857
base: main
Are you sure you want to change the base?
Conversation
Added example for PowerShell and profile location.
I'm not familiar enough with |
I'm guessing you probably need to update documentation in the rust function and it will update everywhere else. src/cli/activate.rs |
@@ -161,5 +161,6 @@ static AFTER_LONG_HELP: &str = color_print::cstr!( | |||
$ <bold>eval "$(mise activate zsh)"</bold> | |||
$ <bold>mise activate fish | source</bold> | |||
$ <bold>execx($(mise activate xonsh))</bold> | |||
$ <bold>(&mise activate pwsh) | Out-String | Invoke-Expression</bold> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the ampersand a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this invokes the command in a non-blocking way. Background Operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would we want that here? Isn't that going to cause the output to not even be parsed by powershell? even if it was, wouldn't it mean the next command might not have the tools setup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also confused why it's at the beginning here but more so why we would want to background this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$(mise activate pwsh) | Out-String | Invoke-Expression
works just the same. But it seems Invoke-Expression -Command $(mise activate pwsh | Out-String)
causes an issue with the parameter length. So the piping is preferred.
We can change it to $(mise activate pwsh) | Out-String | Invoke-Expression
if it is preferred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know, I didn't even see it in the README to be honest. Sorry about that. I'm up for either approach. I'm just personally a fan of modifying my own profile script instead of a script adding it to the end. In the end, I was just following the style of the other nearby examples. I hadn't even thought to look outside the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modifying my own profile script instead of a script adding it to the end. In the end
same here, although with mise it actually is important that it gets loaded last or else the tools might not be in the front of PATH so it's good guidance for us to just tell users to put it at the end
I added an example for PowerShell and profile location. Please let me know if you have any questions.