Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add PowerShell example #3857

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

docs: Add PowerShell example #3857

wants to merge 5 commits into from

Conversation

jahanson
Copy link

I added an example for PowerShell and profile location. Please let me know if you have any questions.

Added example for PowerShell and profile location.
@jahanson jahanson changed the title Add PowerShell example docs: Add PowerShell example Dec 28, 2024
@jahanson
Copy link
Author

I'm not familiar enough with autofix.ci to understand why it reverted my changes.

@fgilcc
Copy link
Contributor

fgilcc commented Dec 29, 2024

I'm guessing you probably need to update documentation in the rust function and it will update everywhere else.

src/cli/activate.rs

@jahanson jahanson marked this pull request as ready for review December 31, 2024 16:09
@@ -161,5 +161,6 @@ static AFTER_LONG_HELP: &str = color_print::cstr!(
$ <bold>eval "$(mise activate zsh)"</bold>
$ <bold>mise activate fish | source</bold>
$ <bold>execx($(mise activate xonsh))</bold>
$ <bold>(&mise activate pwsh) | Out-String | Invoke-Expression</bold>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the ampersand a typo?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this invokes the command in a non-blocking way. Background Operator

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would we want that here? Isn't that going to cause the output to not even be parsed by powershell? even if it was, wouldn't it mean the next command might not have the tools setup?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also confused why it's at the beginning here but more so why we would want to background this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$(mise activate pwsh) | Out-String | Invoke-Expression works just the same. But it seems Invoke-Expression -Command $(mise activate pwsh | Out-String) causes an issue with the parameter length. So the piping is preferred.
We can change it to $(mise activate pwsh) | Out-String | Invoke-Expression if it is preferred.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's what @fgilcc put in the readme and we should at least be consistent. I think we should stick with what @fgilcc has unless they think we should do something different.

If we do want to change it then it would need to happen everywhere in the docs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, I didn't even see it in the README to be honest. Sorry about that. I'm up for either approach. I'm just personally a fan of modifying my own profile script instead of a script adding it to the end. In the end, I was just following the style of the other nearby examples. I hadn't even thought to look outside the docs.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modifying my own profile script instead of a script adding it to the end. In the end

same here, although with mise it actually is important that it gets loaded last or else the tools might not be in the front of PATH so it's good guidance for us to just tell users to put it at the end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants