fix: Improve fig spec with better generators #3762
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelmig
changed the title
miguelmig
changed the title
|
There's still one nasty eslint complaint about descriptions that I can't get to popup on this repo, still struggling with figuring out how eslint imports rules from other modules..once I figure it out I'll leave a comment here. |
jdx
reviewed
Dec 23, 2024
| @@ -264,7 +264,7 @@ function cliReference(commands: { [key: string]: Command }) { | |||
| x.collapsed = true; | |||
| x.items = Object.keys(command.subcommands) | |||
| .filter( | |||
| (subcommand) => command.subcommands![subcommand].hide !== true, | |||
| (subcommand) => command.subcommands![subcommand].hide !== true | |||
There was a problem hiding this comment.
I'd prefer if we didn't need to enable es5 style everywhere
There was a problem hiding this comment.
Fair point, will investigate if I can use package.json hierarchy to handle this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also prevents some issues that might trigger the autocomplete's linter.
This, together with the changes on usage-cli
1.7.3version, should get the automated PR to pass the linter checks on the autocomplete repo