Fixed version check

jcbvm · Feb 4, 2017 · f60d12c · f60d12c
1 parent 127b325
commit f60d12c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/main/java/com/jvms/i18neditor/editor/Editor.java b/src/main/java/com/jvms/i18neditor/editor/Editor.java
@@ -472,12 +472,10 @@ public void showVersionDialog(boolean newVersionOnly) {
 			} catch (InterruptedException | ExecutionException | TimeoutException e) {
 				data = null;
 			}
-			if (data != null && !VERSION.equals(data.getTagName())) {
+			if (data != null && VERSION.compareToIgnoreCase(data.getTagName()) < 0) {
 				content = MessageBundle.get("dialogs.version.new") + " " +
 						"<strong>" + data.getTagName() + "</strong><br>" + 
-						"<a href=\"" + data.getHtmlUrl() + "\">" + 
-							MessageBundle.get("dialogs.version.link") + 
-						"</a>";
+						"<a href=\"" + data.getHtmlUrl() + "\">" + MessageBundle.get("dialogs.version.link") + "</a>";
 			} else if (!newVersionOnly) {
 				content = MessageBundle.get("dialogs.version.uptodate");
 			} else {

diff --git a/src/main/java/com/jvms/i18neditor/editor/EditorMenuBar.java b/src/main/java/com/jvms/i18neditor/editor/EditorMenuBar.java
@@ -219,7 +219,7 @@ private void setupUI() {
      	helpMenu.setMnemonic(MessageBundle.getMnemonic("menu.help.vk"));
 
      	JMenuItem versionMenuItem = new JMenuItem(MessageBundle.get("menu.help.version.title"));
-     	versionMenuItem.addActionListener(e -> editor.showVersionDialog(true));
+     	versionMenuItem.addActionListener(e -> editor.showVersionDialog(false));
 
      	JMenuItem aboutMenuItem = new JMenuItem(MessageBundle.get("menu.help.about.title", Editor.TITLE));
      	aboutMenuItem.addActionListener(e -> editor.showAboutDialog());