fix empty slice bug (#23)

jbsmith7741 · Aug 20, 2021 · 9fa9ae5 · 9fa9ae5
1 parent 89eae26
commit 9fa9ae5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/unmarshal.go b/unmarshal.go
@@ -211,6 +211,9 @@ func SetField(value reflect.Value, s string, sField reflect.StructField) error {
 	case reflect.Slice:
 		// create a generate slice and recursively assign the elements
 		baseType := reflect.TypeOf(value.Interface()).Elem()
+		if s == "" { // ignore empty slices
+			return nil
+		}
 		data := strings.Split(s, separator)
 		slice := reflect.MakeSlice(value.Type(), 0, len(data))
 		for _, v := range data {

diff --git a/unmarshal_test.go b/unmarshal_test.go
@@ -262,6 +262,10 @@ func TestUnmarshal(t *testing.T) {
 				IntsP: []*int{trial.IntP(1), trial.IntP(2), nil, trial.IntP(3)},
 			},
 		},
+		"empty slice": {
+			Input:    "?Ints=&Strings=",
+			Expected: &testStruct{},
+		},
 		"alias type (dessert)": {
 			Input:    "?Dessert=brownie",
 			Expected: &testStruct{Dessert: brownie},