Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix application.properties completion #238

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Conversation

sbouchet
Copy link
Collaborator

@sbouchet sbouchet commented Oct 9, 2023

reverting to old jsoup because of remark

fixes #213

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?

revertting to old jsoup because of remark

Signed-off-by: Stephane Bouchet <[email protected]>
@sbouchet sbouchet marked this pull request as draft October 10, 2023 08:24
@sbouchet
Copy link
Collaborator Author

needs #236 to be merged before this one.

@sbouchet sbouchet marked this pull request as ready for review October 12, 2023 16:06
@sbouchet sbouchet merged commit 8006556 into jbosstools:main Oct 12, 2023
2 of 3 checks passed
@sbouchet sbouchet deleted the issue-213 branch October 12, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

application.properties autocomplete is not working
1 participant