Towards making smart-importer and beancount-import more cooperative.

[Zburatorul]

Introduced two new methods similar to those present in training.py and new logic.

beancount-import will now look for new_account and unconfirmed_account meta fields in each posting, and understand their presence to mean that the account names of these postings are tentative, potentially new. It will then work in a passthrough mode, offering them for import/modifications.

I don't expect this to actually be merged, but rather to serve as a first draft implementation of the proposal from #23.

[coveralls]

Pull Request Test Coverage Report for Build 227

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-68.9%) to 0.0%

---

Totals
Change from base Build 225:	-68.9%
Covered Lines:	0
Relevant Lines:	0

---

💛 - Coveralls

[jbms]

Thanks for working on this! It looks like you are on the right track. When you have something working, can you add a test?

[dumbPy]

smart-importer wraps the ImporterProtocol.extract and modifies the returned imported_entries.
existing_entries and imported_entries are List[Transaction]. Importers generally write the source posting, and target posting is predicted by smart-importer. deduplication is optional and I see that beancount-import does it well, specially from manually entered transactions and I think this would be a better way to go about it.

We will just need to write a generic ImporterSource(Source) subclass that uses user defined, beancount.ingest.importer.ImporterProtocol importers from the config (possibly wrapped in smart-importer), and if there's a single posting, add Expense:FIXME. Might need more things, but this is all I could think of yet. Will try something if and when I get time.

[Zburatorul]

@dumbPy, I had a look at the code in #62 and I think I'm missing the logic of how it fits in with the program of moving the prediction to smart_importer and using beancount-import for the UI. Are the extra meta fields indicating a tentative account meant to be inserted by something upstream of the Source defined in #62?

[dumbPy]

The ImporterSource balances the amounts by adding FIXME account that beancount_import may make a prediction for and the UI allows you to modify it. If you wrap the ImporterProtocol subclass in smart_importer's PredictPostings hook, it would predict this 2nd posting and the amount would be anyhow balanced. So now you have got 2 postings, 1 source posting with source_desc and date metas and one predicted by smart_importer. This predicted posting is passed through without beancount-import's prediction (since it's not a FIXME posting), but I am hoping this/some other PR will make it editable in frontend.

[dumbPy]

I suppose the UNCONFIRMED_ACCOUNT_KEY is the missing part in this jigsaw. You may add to ImporterSource a func that would add this to any non-source and non-FIXME posting that it may receive from the importer, subject to a bool argument in __init__.

[Zburatorul]

That makes sense. Thanks for the explanation. I'll try weaving it into the code.