fix: screenplay not loaded when importing txt or clap #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The
useEffect
withgetClap
was not detecting changes, refactoring it to usemeta
is a simple fix but I think a better approach is to fill the proper store when settingtimeline.setClap()
to avoid complications withuseEffect
apart of avoiding additional renders. An even better approach could be to have a global store where to proxy calls toTimelineStore
andScriptEditorStore
via a uniquesetClap
, I think we could do that in the future.