Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: screenplay not loaded when importing txt or clap #34

Closed
wants to merge 2 commits into from

Conversation

devniel
Copy link
Collaborator

@devniel devniel commented Aug 13, 2024

Hi,

The useEffect with getClap was not detecting changes, refactoring it to use meta is a simple fix but I think a better approach is to fill the proper store when setting timeline.setClap() to avoid complications with useEffect apart of avoiding additional renders. An even better approach could be to have a global store where to proxy calls to TimelineStore and ScriptEditorStore via a unique setClap, I think we could do that in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant