Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PQ.refine for when you already built PQ once for a similar set of vectors #209

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

jbellis
Copy link
Owner

@jbellis jbellis commented Feb 8, 2024

(first 3 commits are identical to the first 3 from APQ)

@jbellis jbellis requested a review from jkni February 8, 2024 16:57
@jbellis jbellis self-assigned this Feb 8, 2024
Copy link
Collaborator

@jkni jkni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- replace divInPlace() with scale()
- remove add() that had same semantics as addInPlace()
- l2normalize() operates in-place
…ces don't make sense (we have no way to easily compute new centroids from the points assigned to each cluster)
@jbellis jbellis merged commit 926fc7f into main Feb 8, 2024
4 checks passed
@jbellis jbellis deleted the pq-refine branch February 8, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants