optimize reconnectOrphanedNodes #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbellis
force-pushed
the
reconnect-optimize
branch
from
593415b to
742cb97
Compare
|
This overxomplicates things, I will update tomorrow morning. |
jbellis
force-pushed
the
reconnect-optimize
branch
from
742cb97 to
fa51c69
Compare
jkni
reviewed
Feb 8, 2024
jvector-base/src/main/java/io/github/jbellis/jvector/graph/GraphIndexBuilder.java
Outdated
Show resolved
Hide resolved
jvector-base/src/main/java/io/github/jbellis/jvector/graph/GraphIndexBuilder.java
Outdated
Show resolved
Hide resolved
jvector-base/src/main/java/io/github/jbellis/jvector/graph/GraphIndexBuilder.java
Outdated
Show resolved
Hide resolved
|
LGTM. As noted on ETL PR, ETL is missing license header causing checks to fail. Once that's good, tests should be able to run. |
jbellis
force-pushed
the
reconnect-optimize
branch
from
a0b4881 to
ebc4cd5
Compare
| if (nReconnected.get() == 0) { | ||
| break; | ||
| } | ||
| System.out.println("Pass " + i + " reconnected " + nReconnected.get() + " nodes"); |
There was a problem hiding this comment.
You probably want to remove this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a disconnected node's neighbor list for a first attempt at reconnecting it to the rest of the graph; only perform a search for more candidates if all of the neighbors are ineligible.
(Michael's profile shows that the search is overwhelmingly the most expensive part.)
this also parallelizes the reconnection operation.
Applies on top of the ExplicitThreadLocal changes.