Add GraphSearcher::resume #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm excited to have this available! This looks functionally correct, and I like the general structure. I wonder if it would make sense to separate the two functionalities of a node being a candidate (potentially becoming a result, making neighbors candidates) because roundtripping the evictedResults through candidates seems to do wasted work in fetching the neighbors iterator (since all neighbors are already visited). EDIT: I'm actually not sure if this helps, depending on how the evictedResults compare to the current state of the candidates queue. |
jkni
approved these changes
Jan 10, 2024
|
Good point, how about this? |
|
LGTM. |
jkni
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.