fix threadlocal variables being allocated outside of threaded task

jbellis · Feb 8, 2024 · 3411a0d · 3411a0d
1 parent fa51c69
commit 3411a0d
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/jvector-base/src/main/java/io/github/jbellis/jvector/graph/GraphIndexBuilder.java b/jvector-base/src/main/java/io/github/jbellis/jvector/graph/GraphIndexBuilder.java
@@ -242,9 +242,6 @@ private void reconnectOrphanedNodes() {
 
             // reconnect unreachable nodes
             var nReconnected = new AtomicInteger();
-            var gs = graphSearcher.get();
-            var v1 = vectors.get();
-            var v2 = vectorsCopy.get();
             var connectionTargets = ConcurrentHashMap.<Integer>newKeySet();
             parallelExecutor.submit(() -> IntStream.range(0, graph.getIdUpperBound()).parallel().forEach(node -> {
                 if (connectedNodes.get(node) || !graph.containsNode(node)) {
@@ -261,6 +258,10 @@ private void reconnectOrphanedNodes() {
                 // no unused candidate found -- search for more neighbors and try again
                 neighbors = searchPathNeighbors.get(node);
                 if (neighbors == null) {
+                    var gs = graphSearcher.get();
+                    var v1 = vectors.get();
+                    var v2 = vectorsCopy.get();
+
                     var notSelfBits = createNotSelfBits(node);
                     var value = v1.vectorValue(node);
                     NodeSimilarity.ExactScoreFunction scoreFunction = i1 -> scoreBetween(v2.vectorValue(i1), value);