Don't create new ScoreTracker.NoOpTracker each time

jbellis · Jan 3, 2024 · 01e1490 · 01e1490
1 parent 1405bc3
commit 01e1490
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/jvector-base/src/main/java/io/github/jbellis/jvector/graph/GraphSearcher.java b/jvector-base/src/main/java/io/github/jbellis/jvector/graph/GraphSearcher.java
@@ -171,7 +171,7 @@ SearchResult searchInternal(NodeSimilarity.ScoreFunction scoreFunction,
         }
 
         prepareScratchState(view.size());
-        var scoreTracker = threshold > 0 ? new ScoreTracker.NormalDistributionTracker(threshold) : new ScoreTracker.NoOpTracker();
+        var scoreTracker = threshold > 0 ? new ScoreTracker.NormalDistributionTracker(threshold) : ScoreTracker.NO_OP;
         if (ep < 0) {
             return new SearchResult(new SearchResult.NodeScore[0], visited, 0);
         }

diff --git a/jvector-base/src/main/java/io/github/jbellis/jvector/graph/ScoreTracker.java b/jvector-base/src/main/java/io/github/jbellis/jvector/graph/ScoreTracker.java
@@ -21,6 +21,9 @@
 import org.apache.commons.math3.stat.StatUtils;
 
 interface ScoreTracker {
+
+    ScoreTracker NO_OP = new NoOpTracker();
+
     void track(float score);
 
     boolean shouldStop(int numVisited);