Don't copy entire Context objects for template tags when all that is needed is their data #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the context.flatten() to create a dict from the original context, updating the dict with new values as necessary, then turn into a new Context object for rendering.
ababic
changed the title
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
==========================================
- Coverage 98.54% 98.54% -0.01%
==========================================
Files 68 68
Lines 2269 2268 -1
==========================================
- Hits 2236 2235 -1
Misses 33 33
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
==========================================
- Coverage 98.54% 98.54% -0.01%
==========================================
Files 68 68
Lines 2269 2268 -1
==========================================
- Hits 2236 2235 -1
Misses 33 33
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All menu templates currently work by creating a copy of the current context, then updating the copy with new values before rendering it. I think the tags were originally developed with a misunderstanding about what 'context' is, and treating it as a dictionary.
Since we only need the data from the current
Contextobject, and not any other part of it, we should simplify the code by usingcontext.flatten()to create a dictionary, update the the dictionary as required with new values, then create a new Context object from that dictionary to use for rendering.This will also help with #89, as it seems that context objects themselves are immutable when using Jinja2.