Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 5 and python 3.12 and 3.13 test support #511

Closed
wants to merge 2 commits into from

Conversation

dancergraham
Copy link
Contributor

@dancergraham dancergraham requested a review from ulgens November 7, 2024 15:49
Copy link
Member

@ulgens ulgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I'm the right person to give reviews on this package but I think other people will agree that this PR does too much. Python 3.8 removal, Github Actions updates, partial Django 3.2 removal, 4.0 and 4.1 removal, Django 5.1 support and then Python 3.12 and 3.13 support. Almost all of them deserve their own comprehensive PR.

@clintonb
Copy link
Collaborator

clintonb commented Nov 8, 2024

I agree that there is too much here. Please create separate pull requests for updating Actions and adding support for new Python and Django versions. We can drop support for EOL’d versions in a later, major, release.

@dancergraham
Copy link
Contributor Author

Hi thanks for the review ! yes I agree that this is mixing subjects, as did the PR I based it on. I will try to find some time to redo it in separate steps...

@ulgens ulgens mentioned this pull request Nov 8, 2024
Comment on lines +19 to +21
django50: Django>=5.0,<5.1
django51: Django>=5.1,<5.2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
django50: Django>=5.0,<5.1
django51: Django>=5.1,<5.2
django50: Django>=5.0,<5.1
django51: Django>=5.1,<5.2

"Framework :: Django :: 4.2",
"Framework :: Django :: 5.0",
"Framework :: Django :: 5.1",
"Framework :: Django :: 5.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Framework :: Django :: 5.2",

Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Git conflicts to resolve.

@dancergraham
Copy link
Contributor Author

Handled elsewhere - 9 PRs is better than one ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants