Throw an error in FieldTracker when using untracked field with .previous #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furious-luke
changed the title
previous
furious-luke
changed the title
|
@furious-luke The test failures look related to these changes. |
Natim
reviewed
Aug 21, 2019
| @@ -66,14 +66,14 @@ def current(self, fields=None): | |||
|
|
|||
| def has_changed(self, field): | |||
| """Returns ``True`` if field has changed from currently saved value""" | |||
| if field in self.fields: | |||
There was a problem hiding this comment.
@furious-luke shall we keep the if in both methods? Can you add a test for your change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously if
previouswas called on a field tracker and the field was not being tracked it would returnNone. Having consistent behavior betweenpreviousandhas_changedwould seem to make sense, but there may be a reason why this is not so?Solution
I've moved the
FieldErrorexception intopreviousfromhas_changed;has_changedcallespreviousso the exception will still be used fromhas_changed.Commandments
CHANGES.rstfile to describe the changes, and quote according issue withGH-<issue_number>.I can add a test for this if you think it's worth merging?