-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass through redirect query arg #233
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 64.34% 65.71% +1.36%
==========================================
Files 18 18
Lines 474 490 +16
==========================================
+ Hits 305 322 +17
+ Misses 169 168 -1 ☔ View full report in Codecov by Sentry. |
pre-commit.ci autofix |
Hi @blag Nice work! 👏 Python 3.7 has been dropped in 2.1.0 - so we can revert the mentioned commit 😊 Also there is a conflict. I'll approve and merge when those issues are resolved 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reintroduce the walrus operator 🦭
Fix conflict.
🚀
39d4262
to
51e481e
Compare
Removed commit and fixed conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 👏
Hey @valberg, thanks for the merge. Do you mind tagging a release? I have a project that needs my fix and I'd like to specify a version instead of a commit hash for it. 😄 |
Fixes #231.
Pass through a
next=...
query parameter to the signup and login views.The docs for
SIGNUP_REDIRECT
andLOGIN_REDIRECT
indicate they should be a URL name, the default values for these settings are URL names, and the tests for the allauth backend do not override those options and so expect a URL name.But the tests for the basic backend override that option with a direct URL:
Which is why I do this in this PR:
Fixing this may not be backwards compatible with existing users. It is also best left for a separate discussion, so for this PR I allowed for both options.
I also removed the walrus operator in a separate commit, so once we drop support for Python 3.7 we can revert that single commit to use the walrus operator.