Document how to not trigger a download #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be used in documentation for issue jazzband#80
Responsive to issue jazzband#80
|
Hi @quietlyconfident, and thanks for the pull-request! What about the following changes?
|
| @@ -61,6 +61,18 @@ Then here is the code to serve "another_file" instead of the default "file": | |||
| :language: python | |||
| :lines: 1-5, 10-12 | |||
|
|
|||
| *********************************************** | |||
| Serving a file inline rather than as a download | |||
There was a problem hiding this comment.
Is "attachment" more pertinent than "download" here?
| @@ -16,3 +16,8 @@ | |||
| deserialized_basename_view = ObjectDownloadView.as_view( | |||
| model=Document, | |||
| basename_field='basename') | |||
|
|
|||
| #: Serve ``file`` attribute of ``Document`` model, inline rather than as attachment | |||
There was a problem hiding this comment.
Flake8 reports: "line too long (83 > 79 characters)".
See https://travis-ci.org/benoitbryon/django-downloadview/jobs/18602404#L49
What about #: Serve ``file`` attribute of ``Document`` model, inline (not as attachment).
Or span the comment on 2 lines :)
|
Hi @quietlyconfident, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responsive to Issue #80.