Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version #408

Closed
wants to merge 4 commits into from
Closed

Bump version #408

wants to merge 4 commits into from

Conversation

Mogost
Copy link
Member

@Mogost Mogost commented Jun 10, 2020

I think we all did a good job and deserve a new release.

@Mogost Mogost requested a review from jezdez June 10, 2020 17:27
@Mogost
Copy link
Member Author

Mogost commented Jun 10, 2020

I checked this version on my project and at first glance everything works.

@jezdez
Copy link
Member

jezdez commented Jun 10, 2020

I just merged #394 as well, mind adding that please?

@Mogost
Copy link
Member Author

Mogost commented Jun 10, 2020

Done

@jezdez jezdez requested a review from camilonova June 10, 2020 17:59
@jezdez
Copy link
Member

jezdez commented Jun 10, 2020

@camilonova (NOT TIME SENSITIVE:) Hey, just checking in to see if you have any issues with this going out?

@david-griffiths-eigen
Copy link

david-griffiths-eigen commented Jun 15, 2020 •
edited
Loading

How close is this version from being released? The In-memory backend is already in the documentation...

@Mogost
Copy link
Member Author

Mogost commented Jun 16, 2020 •
edited
Loading

@jezdez can we do something to make the release faster?
I once again reviewed all changes point-by-point.

Tested or safe changes Safely remove obsolete code - [x] Delete south migrations

Not Functional Changes (docs/examples/setup.cfg)

  • Improve grammar of documentation index file
  • Simplify documentation installation section
  • Update example project for Django>2
  • Put back wheel generation in travis

Changes I personally verified

  • Fix IntegrityError after 2.5.0 release (Allow concurrent calls to DatabaseBackend.set() method)
  • Fix wrong "is modified" in admin for multi line strings
  • Added a sticky footer in django constance admin
  • Add anchors in admin for constance settings
  • Make constance app verbose name translatable
  • Fix Attempts to change config values fail silently and appear to succeed when user does not have change permissions
  • Make groups of fieldsets collapsable

Affects only tests

  • Allow override_config for pytest
  • Add memory backend

Changes that are doubtful or unverified

  • Switch md5 to sha256
    (I just do not understand these changes and whether they can have any negative effect.)

I found #409 But I do not think that this should block the release.

@Mogost Mogost mentioned this pull request Jun 16, 2020
Closed
@camilonova
Copy link
Member

Merged in 96e95fc

@camilonova camilonova closed this Jun 22, 2020
@david-griffiths-eigen
Copy link

Thanks guys! Appreciate your efforts 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilonova camilonova camilonova approved these changes

@jezdez jezdez Awaiting requested review from jezdez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mogost @jezdez @david-griffiths-eigen @camilonova