Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new management command axes_reset_ip_username #1138

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Add new management command axes_reset_ip_username #1138

merged 1 commit into from
Dec 8, 2023

Conversation

p-l-
Copy link
Contributor

@p-l- p-l- commented Nov 15, 2023

What does this PR do?

This PR adds a new management command axes_reset_ip_username that just... does what its name says!

Before submitting

  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@p-l- p-l- marked this pull request as ready for review November 15, 2023 20:29
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (efe08b7) 94.46% compared to head (6e64c62) 94.35%.
Report is 18 commits behind head on master.

Files Patch % Lines
axes/management/commands/axes_reset_ip_username.py 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
- Coverage   94.46%   94.35%   -0.12%     
==========================================
  Files          34       35       +1     
  Lines        1139     1151      +12     
  Branches      210      211       +1     
==========================================
+ Hits         1076     1086      +10     
- Misses         48       49       +1     
- Partials       15       16       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aleksihakli
Copy link
Member

https://github.com/jazzband/django-axes/actions/runs/6981036981/job/19064759864?pr=1138#step:7:127

@p-l-
Copy link
Contributor Author

p-l- commented Nov 28, 2023

Thanks @aleksihakli I had totally missed this test!

@p-l-
Copy link
Contributor Author

p-l- commented Dec 7, 2023

Hi @aleksihakli 👋
Can you approve the workflows run again?

@aleksihakli aleksihakli merged commit 2a0fd0c into jazzband:master Dec 8, 2023
19 checks passed
@p-l- p-l- deleted the command-reset-ip-username branch December 9, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants