Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

chore: Add changes for rust 2018 edition #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions csv-query-cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ version = "0.5.0"
description = "Make SQL queries on CSV files (cli)"
license = "MIT"
readme = "../README.md"
edition = "2018"

authors = ["Jayson Reis <[email protected]>"]

Expand Down
8 changes: 1 addition & 7 deletions csv-query-cli/src/main.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
extern crate clap;
extern crate directories;
#[macro_use]
extern crate error_chain;
extern crate rustyline;

extern crate csv_query;
use error_chain::quick_main;

mod arguments;
mod interactive;
Expand Down
6 changes: 4 additions & 2 deletions csv-query-cli/src/process.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
use std::fs::File;
use std::io;

use error_chain::bail;

use csv_query::errors::{Result, ResultExt};
use csv_query::Executor;

use arguments;
use interactive::run_interactive;
use crate::arguments;
use crate::interactive::run_interactive;

pub(crate) fn process() -> Result<()> {
let matches = arguments::build().get_matches();
Expand Down
1 change: 1 addition & 0 deletions csv-query/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ description = "Make SQL queries on CSV files"
version = "0.5.0"
license = "MIT"
readme = "../README.md"
edition = "2018"

[dependencies]
csv = "^1.0.0"
Expand Down
9 changes: 8 additions & 1 deletion csv-query/src/errors.rs
Original file line number Diff line number Diff line change
@@ -1 +1,8 @@
error_chain!{}
// TODO: Remove these imports after https://github.com/rust-lang-nursery/error-chain/pull/253 is released
use error_chain::error_chain;
use error_chain::error_chain_processing;
use error_chain::impl_error_chain_kind;
use error_chain::impl_error_chain_processed;
use error_chain::impl_extract_backtrace;

error_chain! {}
6 changes: 3 additions & 3 deletions csv-query/src/executor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ use std::path::Path;
use csv;
use rusqlite;

use csv_utils::string_to_csv_output;
use db_utils::{escape_columns, escape_values, AllString};
use errors::{Result, ResultExt};
use crate::csv_utils::string_to_csv_output;
use crate::db_utils::{escape_columns, escape_values, AllString};
use crate::errors::{Result, ResultExt};

/// Main struct that parses the CSV and put the data into a SQLite
pub struct Executor<W: Write> {
Expand Down
7 changes: 1 addition & 6 deletions csv-query/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
extern crate csv;
#[macro_use]
extern crate error_chain;
extern crate rusqlite;

mod csv_utils;
mod db_utils;
pub mod errors;
pub mod executor;

pub use executor::Executor;
pub use crate::executor::Executor;
5 changes: 2 additions & 3 deletions csv-query/tests/executor.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
extern crate csv_query;

use std::io::{BufReader, Cursor, Write};

use csv_query::Executor;
Expand Down Expand Up @@ -47,7 +45,8 @@ fn test_join() {
on u.user = o.user
group by u.user
having sum(price) > 50",
).unwrap();
)
.unwrap();
}
let output = output_buffer.into_inner();
assert_eq!(
Expand Down