snapshot: initial support to collect data pertaining to network interfaces #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading network interface information from a snapshot, invoking ethtool is useless at best, misleading at worst. We start allowing the users which want to consume a snapshot to disable the ethtool invocation. The default is to keep the existing behaviour and call ethtool if available. Signed-off-by: Francesco Romani <[email protected]>
We split the discovery of the list of the files we want to collect for snapshotting purposes because the list depends on the host specific details; we want to filter out the virtual devices - they are not about hardware after all. hence, we need to do some runtime discovery. Signed-off-by: Francesco Romani <[email protected]>
jaypipes
approved these changes
Feb 23, 2021
| The most common use case is when we want to consume a snapshot from ghw. In these cases the information | ||
| provided by tools will be most likely inconsistent with the data from the snapshot - they will run on | ||
| a different host! | ||
| To make ghw not calling external tools, set the environs variable `GHW_DISABLE_TOOLS` to any value, |
There was a problem hiding this comment.
s/To make ghw not calling external tools/To prevent ghw from calling external tools/
ffromani
added a commit
to ffromani/ghw
that referenced
this pull request
Feb 23, 2021
Some spelling error sneaked in alongside jaypipes#227 Let's fix them. Signed-off-by: Francesco Romani <[email protected]>
Sure thing! #228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more prep work for collecting SRIOV-related data (#92). We want to make sure that:
ethtooland other tools